fix(button): update styling for badge #30414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-pedrolourenco
changed the title
thetaPC
requested changes
May 19, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Please update the PR title to be a fix since the PR is aiming to change the outcome to reflect the true styles.
OS-pedrolourenco
changed the title
thetaPC
requested changes
May 23, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Just needs to have ios and md styles to match ionic when it comes to positioning. If the positions are the same, then we can move the styles to the common file.
...adge/test/hint/badge.e2e.ts-snapshots/badge-hint-button-size-ios-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...badge/test/hint/badge.e2e.ts-snapshots/badge-hint-button-size-md-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Some stylings for the ion-badge when slotted in an ion-button were missing.
What is the new behavior?
Updated the styling for the ion-badge when slotted in an ion-button according to the designs:
:haspseudo-selector for a simple 'button-had-badge' class;Does this introduce a breaking change?
Other information